Add java.lang.reflect.Type to TypeRef per #331#449
Merged
artursouza merged 2 commits intoJan 22, 2021
Conversation
artursouza
previously approved these changes
Jan 22, 2021
pkedy
changed the title
artursouza
approved these changes
Jan 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
============================================
+ Coverage 83.27% 83.30% +0.02%
- Complexity 859 861 +2
============================================
Files 74 74
Lines 2565 2569 +4
Branches 261 261
============================================
+ Hits 2136 2140 +4
Misses 301 301
Partials 128 128
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
public static <T> TypeRef<T> get(Type type)toTypeRefAdded bonus: Having the generic
<T>seems to work even if it isn't passed in as an argument.Resolves issue #331
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: